fix MutableLinkedList when appending empty list #915
Conversation
|
@oxinabox I apologize for tagging you directly: I'm new to contributing, so I'm not sure if that's OK. The changes here are minimal, yet having an infinite iteration every time I try to append an empty list is troublesome. I resort to using my own local version of the package in the meantime. Would you mind reviewing the PR? I'm not sure which of the two options (if any) is better. Thank you. |
|
tagging me is fine. In general I hate the linked list code and want to just delete all of it. |
|
@yohmercy could you perhaps add a test that demonstrates the bug fix works (i.e. something that fails now and works correctly with your patch) |
Currently
append!(MutableLinkedList{Int}(1), MutableLinkedList{Int}())results in an infinite iteration. This is due to the order of sentinel-node reassignments and the second list being empty. One way to fix that is by using something likeisempty(l2) && return l1at the top of theappend!method. Another (proposed in this PR) is to just reorder the reassignments. The former is more straightforward, the latter adds no new code.